Ruby: fix bug with captured variable reads in lambdas #8517
+56
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reveals a bug where we identify reads of captured variables in lambdas as method calls. This is fixed in a followup commit.
These were previously identified as method calls. The fix is to recognise lambdas as a scope which can inherit variables from its parent.
hvitved
approved these changes
Mar 23, 2022
| # calls inside lambdas | ||
| y = 1 | ||
| id = ->(x) { y } |
There was a problem hiding this comment.
nit: I would call it e.g. one, id makes me expect that it is the identify function.
There was a problem hiding this comment.
Oh true, haha. I think I initially wrote the identity function and then changed it to be relevant to this fix...
There was a problem hiding this comment.
I'll fix this in a followup PR, so you don't have to re-approve this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
In the following example, we currently identify the read of
xas a method call:This change fixes that, so we instead identify it as a captured variable read.
Evaluation shows no significant performance impact, and otherwise no changes that I can see.