Python: switch to shared implementation of IncompleteHostnameRegExp.ql #8486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HostnameRegExp.ql"" This reverts commit 6d24591.
aibaars
commented
Mar 18, 2022
| RegExpTerm getParsedRegExp(StrConst re) { result.getRegex() = re and result.isRootTerm() } | ||
|
|
||
| /** | ||
| * A node whose value may flow to a position where it is interpreted |
Contributor
Author
There was a problem hiding this comment.
@tausbn You asked for this class to me moved to another location. Could you tell me the preferred place?
Contributor
There was a problem hiding this comment.
I would just create a file in lib/semmle/python/dataflow/new called Regex.qll, and import it appropriately. Would that be okay?
yoff
reviewed
Mar 21, 2022
Contributor
yoff
left a comment
yoff
left a comment
There was a problem hiding this comment.
This looks good to me now, although there are a bunch of QL warnings.
Really nice to see this sharing!
aibaars
force-pushed
the
incomplete-hostname-python
branch
from
30dd1c0 to
41bd644
Compare
aibaars
force-pushed
the
incomplete-hostname-python
branch
from
41bd644 to
79cd7bf
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.