Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up CODEOWNERS #31715

Merged
merged 1 commit into from Mar 7, 2022
Merged

Clean up CODEOWNERS #31715

merged 1 commit into from Mar 7, 2022
+8 −16

Conversation

JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented Mar 7, 2022

crypto-team apparently doesn't exist and skrah no longer has write access. Thanks @isidentical for noticing this.

@JelleZijlstra
Clean up CODEOWNERS
3eb23ba 
crypto-team apparently doesn't exist and skrah no longer has write access. Thanks @isidentical for noticing this.
orsenthil
orsenthil approved these changes Mar 7, 2022
View changes
Copy link
Member

@orsenthil orsenthil left a comment

LGTM

@orsenthil orsenthil merged commit e38d0df into main Mar 7, 2022
12 checks passed
@orsenthil orsenthil deleted the JelleZijlstra-patch-1 branch Mar 7, 2022
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 7, 2022

Thanks @JelleZijlstra for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Mar 7, 2022

@orsenthil: Please replace # with GH- in the commit message next time. Thanks!

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 7, 2022

Sorry, @JelleZijlstra and @orsenthil, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker e38d0dfe92c28e081a46a5a858ac26bd6a14aded 3.10

@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Mar 7, 2022

Sorry @JelleZijlstra and @orsenthil, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker e38d0dfe92c28e081a46a5a858ac26bd6a14aded 3.9

@JelleZijlstra
Copy link
Member Author

@JelleZijlstra JelleZijlstra commented Mar 7, 2022

I'll take a look at the backports. I'm not 100% sure it even matters——maybe GH only looks at this file on the default branch.

@JelleZijlstra
Copy link
Member Author

@JelleZijlstra JelleZijlstra commented Mar 7, 2022

And thanks for merging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil

Assignees

@JelleZijlstra JelleZijlstra

Labels
CLA signed needs backport to 3.9 needs backport to 3.10 skip issue skip news
Projects
None yet
Milestone
No milestone
5 participants
@JelleZijlstra @miss-islington @bedevere-bot @orsenthil @the-knights-who-say-ni