Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pip updates during the installation of the virtual env #688

Merged
merged 3 commits into from May 12, 2021

Conversation

matrixise
Copy link
Member

@matrixise matrixise commented May 5, 2021

No description provided.

@matrixise matrixise requested review from JulienPalard and Mariatta May 7, 2021
@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented May 7, 2021

I don't think it make sense to update pip while installing requirements. It would make sense to upgrade pip first, then use the new pip to install requirements.

Do you hit an issue with a venv created with a too-old pip?

@matrixise
Copy link
Member Author

@matrixise matrixise commented May 10, 2021

@JulienPalard

Do you prefer this commit? f38e5a5

About the issue, just the warning (outdated version of pip) that pollutes my terminal

@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented May 11, 2021

Do you prefer this commit? f38e5a5

Yes I prefer it this way, so the pip used to install requirement is the new one, not the old one.

@matrixise
Copy link
Member Author

@matrixise matrixise commented May 11, 2021

@JulienPalard updated.

@JulienPalard JulienPalard merged commit d292422 into python:master May 12, 2021
3 checks passed
@JulienPalard
Copy link
Member

@JulienPalard JulienPalard commented May 12, 2021

Thanks @matrixise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants