C++: Split 'gets' model. #7703
Merged
C++: Split 'gets' model. #7703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasVP
previously approved these changes
Jan 21, 2022
Contributor
MathiasVP
left a comment
MathiasVP
left a comment
There was a problem hiding this comment.
LGTM! Both of my comments are really something that we should fix as follow-ups, so feel free to merge this PR without changing anything.
Contributor
Author
|
Fixed formatting. |
MathiasVP
reviewed
Jan 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand it
getsshould be aLocalFlowSourceFunctionnot aRemoteFlowSourceFunction(unlikefgetswhich may at least be a remote source). Fixing this required splitting the model in two, though a few parts did simplify afterwards.This change is mostly for correctness but will fix the odd false positive, such as the test case added for
cpp/cleartext-transmission(which confusingly is and remains a true positive forcpp/cleartext-storage-buffer, tested alongside, because that query is defined to not care about it being a remote source).