Added type hint in enqueue function #5894
Conversation
ghost
added
enhancement
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| self.queue = [] | ||
| self.size = 0 | ||
|
|
||
| def enqueueFront(self, val: Any) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/double_ended_queue_list.py, please provide doctest for the function enqueueFront
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: enqueueFront
| self.queue.insert(0, val) | ||
| self.size += 1 | ||
|
|
||
| def enqueueEnd(self, val: Any) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/double_ended_queue_list.py, please provide doctest for the function enqueueEnd
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: enqueueEnd
| self.queue.append(val) | ||
| self.size += 1 | ||
|
|
||
| def dequeueFront(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/double_ended_queue_list.py, please provide doctest for the function dequeueFront
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: dequeueFront
| self.queue = self.queue[1:] | ||
| self.size -= 1 | ||
|
|
||
| def dequeueEnd(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/double_ended_queue_list.py, please provide doctest for the function dequeueEnd
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: dequeueEnd
| self.queue = self.queue[:-1] | ||
| self.size -= 1 | ||
|
|
||
| def printQueue(self) -> None: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/double_ended_queue_list.py, please provide doctest for the function printQueue
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: printQueue
| def printQueue(self) -> None: | ||
| print(*self.queue, sep=' ') | ||
|
|
||
| def queueSize(self) -> int: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file data_structures/queue/double_ended_queue_list.py, please provide doctest for the function queueSize
Variable and function names should follow the snake_case naming convention. Please update the following name accordingly: queueSize
1 participant
Describe your change:
Checklist:
Fixes: #{$ISSUE_NO}.I added type hint in the enqueue function which was missing previously