-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Java: Add models for java.util.regex.Pattern and Matcher #7733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Click to show differences in coveragejavaGenerated file changes for java
- Java Standard Library,``java.*``,3,533,111,28,,,7,,,10
+ Java Standard Library,``java.*``,3,541,111,28,,,7,,,10
- Totals,,182,6212,1424,106,6,10,107,33,1,81
+ Totals,,182,6220,1424,106,6,10,107,33,1,81
- java.util,34,,430,,,,,,,,,,34,,,,,,,,,,,,,,,16,414
+ java.util,34,,438,,,,,,,,,,34,,,,,,,,,,,,,,,24,414 |
|
The test doesn't compile: Otherwise this looks good to me. I imagine this will expose FPs because people are using regexes to sanitize things and we've previously by default assumed that any regex is sanitizing, but I'd be in favour of accepting these models and selectively introducing regex sanitizer steps as required. |
Click to show differences in coveragejavaGenerated file changes for java
- Java Standard Library,``java.*``,3,533,111,28,,,7,,,10
+ Java Standard Library,``java.*``,3,541,111,28,,,7,,,10
- Totals,,182,6212,1424,106,6,10,107,33,1,81
+ Totals,,182,6220,1424,106,6,10,107,33,1,81
- java.util,34,,430,,,,,,,,,,34,,,,,,,,,,,,,,,16,414
+ java.util,34,,438,,,,,,,,,,34,,,,,,,,,,,,,,,24,414 |
|
Thanks @smowton I updated the test file and made it more meaningful |
|
Might want to clear up the tabs/spaces situation. Otherwise LGTM |
|
ready for review @smowton |
Click to show differences in coveragejavaGenerated file changes for java
- Java Standard Library,``java.*``,3,533,111,28,,,7,,,10
+ Java Standard Library,``java.*``,3,541,111,28,,,7,,,10
- Totals,,182,6212,1424,106,6,10,107,33,1,81
+ Totals,,182,6220,1424,106,6,10,107,33,1,81
- java.util,34,,430,,,,,,,,,,34,,,,,,,,,,,,,,,16,414
+ java.util,34,,438,,,,,,,,,,34,,,,,,,,,,,,,,,24,414 |
This PR adds summaries for java.util.regex Pattern and Matcher so that taint can flow in cases such as: