Ruby: Desugar hash literals #7750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
ruby/desugar-hash-literals
branch
from
02743f9 to
5259a99
Compare
hvitved
force-pushed
the
ruby/desugar-hash-literals
branch
from
5259a99 to
7ccb747
Compare
```rb
{ a: 1, **splat, b: 2 }
```
becomes
```rb
::Hash.[](a: 1, **splat, b: 2)
```
hvitved
force-pushed
the
ruby/desugar-hash-literals
branch
from
7ccb747 to
dd27ed8
Compare
hmac
previously approved these changes
Jan 27, 2022
Contributor
hmac
left a comment
hmac
left a comment
There was a problem hiding this comment.
Just have a few minor comments, this looks good and is nice and understandable!
I guess when we start to write flow summaries for methods involving hashes, we'll make use of the TKeywordArgumentPosition/TKeywordParameter position variants in order to specify them?
hmac
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
becomes