Skip to content

C# 10 - Lambda improvements. #7749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelnebel merged 14 commits into from
Feb 8, 2022
Merged

C# 10 - Lambda improvements. #7749

michaelnebel merged 14 commits into from
Feb 8, 2022

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 26, 2022 •
edited
Loading

In this PR, we make support for C# 10 Improvements on lambda expressions

  • Lambda expressions may have a natural type, where the compiler can infer a delegate type from the lambda expression or method group (test only).
  • Lambda expressions may declare a return type when the compiler can't infer it.
  • Attributes can be applied to lambda expressions.

What is still needed in this PR

@github-actions github-actions bot added the C# label Jan 26, 2022
@michaelnebel michaelnebel force-pushed the csharp/lambda-improvements branch from 6922c09 to a906464 Compare January 28, 2022 08:19
@michaelnebel
C#: Example of naturally typed lambda.
a670330
@michaelnebel
C#: Test cases that shows that lambdas can be naturally (implicitly) …
ccb727e 
…typed and that the type is indistinguishable from the equivalent explicitly typed declaration.
@michaelnebel
C#: Add table for explicit return type in lambda expressions.
ae62704
@michaelnebel
C#: Add support for explicit return types in the extractor.
eb8c226
@michaelnebel
C#: Add support QL library support for lambda explicit return types.
25019db
@michaelnebel
C#: Examples of lambda expressions with explicit return types.
83a5ef4
@michaelnebel
C#: Add test case for finding lambdas with explicit return types.
7520948
@michaelnebel
C#: Update test cases(s) expected output.
bb3f9ce
@michaelnebel
C#: Add some examples lambdas with different kind of attributes and u…
f412d49 
…pdate existing testcases.
@michaelnebel
C#: Modify database schema to allow lambda expression to be attributa…
7b3ba3c 
…ble and extract the lambda expression attributes.
@michaelnebel
C#: Add lambda attributes test cases.
6ee3084
@michaelnebel michaelnebel force-pushed the csharp/lambda-improvements branch from a906464 to 6ee3084 Compare February 4, 2022 15:55
@michaelnebel michaelnebel marked this pull request as ready for review February 7, 2022 08:36
@michaelnebel michaelnebel requested a review from a team as a code owner February 7, 2022 08:36
hvitved
hvitved reviewed Feb 7, 2022
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Go ahead with generating and adding new stats.

@michaelnebel
Copy link
Contributor Author

michaelnebel commented Feb 8, 2022

DCA run shows that performance is not affected.

@michaelnebel michaelnebel requested a review from hvitved February 8, 2022 08:42
@michaelnebel michaelnebel merged commit c04e344 into github:main Feb 8, 2022
@michaelnebel michaelnebel deleted the csharp/lambda-improvements branch February 8, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C# documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelnebel @hvitved