Skip to content

Conversation

@edoardopirovano
Copy link
Contributor

This PR fixes two issues with the release process for downgrade packs:

  1. An existing downgrade pack has a version number lower than the others because it didn't make it into the release branch and therefore didn't get released when the others did. Bump it to bring it back in sync.
  2. The automation for releasing packs isn't picking up downgrade ones because they aren't listed in our .codeqlmanifest.json, so even if it had been on the release branch it would not have been released correctly as things stand.

@edoardopirovano edoardopirovano requested a review from a team as a code owner January 26, 2022 09:39
@edoardopirovano edoardopirovano added the no-change-note-required This PR does not need a change note label Jan 26, 2022
@github-actions github-actions bot added the C# label Jan 26, 2022
@aibaars
Copy link
Contributor

aibaars commented Jan 26, 2022

Have you checked that C# still works well in VSCode? There might be a reason why downgrades are not in the normal ql folder.

@edoardopirovano
Copy link
Contributor Author

Have you checked that C# still works well in VSCode? There might be a reason why downgrades are not in the normal ql folder.

Good point. I've run a couple of queries in VS code and clicked around the standard library including in the parts affected by the downgrade script (i.e. the DB scheme for the new relation, and some bits of the QL source that use it). All seems to work smoothly.

As for where these packs should be. I'm not sure how conscious the decision to not put them in ql was (@michaelnebel can comment on that). Regardless of where the pack goes, we'll need a new line in the manifest since the existing patterns won't match ql/upgrades either.

@cklin
Copy link
Contributor

cklin commented Jan 26, 2022

Thank you @edoardopirovano! Tagging https://github.com/github/codeql-core/issues/1717 so that we can find this PR later.

@edoardopirovano
Copy link
Contributor Author

Thank you @edoardopirovano! Tagging https://github.com/github/codeql-core/issues/1717 so that we can find this PR later.

👍

Note I've held off on merging this as @dbartol mentioned we may not want to release the downgrade packs after all.

@edoardopirovano
Copy link
Contributor Author

Closing as we have decided to not publish these packa to the registry after all.

@edoardopirovano edoardopirovano deleted the fix-downgrade-packs branch May 10, 2022 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants