Ruby extractor: bump clap #7729
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates the requirements on [clap](https://github.com/clap-rs/clap) to permit the latest version. Apply this update in both the generator and extractor.
Contributor
|
Looks good to me, but make sure to check that is also works for M1 Macs. We've had problems in the past with new versions of crates not being available for that architecture. |
Contributor
Author
|
@aibaars that's a good point - how do I test that? I don't have one myself. |
Contributor
Author
|
Confirmed this builds successfully on M1. |
aibaars
approved these changes
Jan 26, 2022
This was referenced Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supersedes #7499 and #7556 by bumping the
clapdependency in bothgeneratorandextractor. It also fixes a warning arising from the version bump (clap::App::args_from_usageis deprecated).The original PRs didn't update
Cargo.lock, which looked a bit suspicious.