JS: add a predicate to recognize path arguments in calls to the fs-extra lib #7715
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Adding @esbena as reviewer, as he is already in the loop. |
esbena
requested changes
Jan 24, 2022
Contributor
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
Thanks for doing this! I'm excited about the evaluation, could you do one with code-scanning.qls and default.yml?
The semantics of this looks fine, but there are two tangential issues. See inline comments.
Co-authored-by: Esben Sparre Andreasen <[email protected]>
owen-mc
changed the title
esbena
approved these changes
Jan 24, 2022
Contributor
|
Great. Merge at will. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sending this PR because the lack of complete support for
fs-extra(ca 60.000.000 downloads weekly) has led to at least one false negative (see here: https://lgtm.com/projects/g/strongloop/strong-arc/snapshot/ac18d2c147b10c94552f215b1016216bb580d3ff/files/client/test/test-server.js?sort=name&dir=ASC&mode=heatmap#L89, it's a FN since fs.remove is not currently recognized as a sink. This PR fixes the problem.)