C#: Make support for Line span pragma #7577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/line-pragma
branch
from
8df9b2b to
e75b38e
Compare
…plementation to use the new types.
michaelnebel
force-pushed
the
csharp/line-pragma
branch
from
c5efd30 to
de3d62b
Compare
Contributor
Author
|
Need to also look into the SourceLocation stuff (forgot that). Will write something here, when investigation is finished. |
Contributor
Author
Tried to do some dev testing of this and looks like it is working out of the box. query predicate elements(Assignment statement, File f) { statement.getLocation().getFile() = f }Which among other things produced the output | LinePragmasRef1.cs:1:9:1:13 | Int32 i = ... | LinePragmasRef1.cs:0:0:0:0 | LinePragmasRef1.cs |
| LinePragmasRef2.cs:2:13:2:17 | Int32 j = ... | LinePragmasRef2.cs:0:0:0:0 | LinePragmasRef2.cs |and it looks like this respects the line span pragma info. |
Contributor
Author
|
Ready for review. |
tamasvajk
reviewed
Jan 19, 2022
hvitved
requested changes
Jan 19, 2022
...rp/extractor/Semmle.Extraction.CSharp/Entities/PreprocessorDirectives/LineOrSpanDirective.cs
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction.CSharp/Entities/PreprocessorDirectives/LineSpanDirective.cs
Show resolved
Hide resolved
csharp/extractor/Semmle.Extraction.CSharp/Entities/PreprocessorDirectives/LineSpanDirective.cs
Outdated
Show resolved
Hide resolved
hvitved
approved these changes
Jan 19, 2022
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
LGTM. Then we just need a final DCA run, since the stats have been updated.
Contributor
Author
Great! I will start one. |
Contributor
Author
|
Execution times are looking good. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C# 10 introduced a new #line pragma, where it is possible to specify, how start and end (line and column) including an offset should be printed, when a compiler warning is issued.
In the PR we