Refactor sanitizer skip tests into test.support #30889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlend-aasland
approved these changes
Jan 25, 2022
Lib/test/support/__init__.py
Outdated
| '--with-memory-sanitizer' in _config_args | ||
| ) | ||
| address_sanitizer = ( | ||
| '-fsanitize=address' in _cflags |
There was a problem hiding this comment.
Also check '--with-memory-sanitizer' in _config_args
|
I'd add a NEWS entry and possibly document it in the test support section. |
erlend-aasland
reviewed
Jan 25, 2022
Lib/test/support/__init__.py
Outdated
| @@ -55,6 +55,7 @@ | |||
| "run_with_tz", "PGO", "missing_compiler_executable", | |||
| "ALWAYS_EQ", "NEVER_EQ", "LARGEST", "SMALLEST", | |||
| "LOOPBACK_TIMEOUT", "INTERNET_TIMEOUT", "SHORT_TIMEOUT", "LONG_TIMEOUT", | |||
| "skip_if_sanitizer", | |||
There was a problem hiding this comment.
Nit: this probably belongs in the unittest section between line 34 and 44.
The news section is for user visible changes, this is an internal change. |
erlend-aasland
approved these changes
Jan 25, 2022
vstinner
added a commit
that referenced
this pull request
Mar 2, 2022
…H-31634) * Refactor sanitiser skip tests into test.support (GH-30889) * Refactor sanitizer skip tests into test.support (cherry picked from commit b1cb843) * Add skips to crashing tests under sanitizers instead of manually skipping them (GH-30897) (cherry picked from commit a275053) * bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) Skip tests on ASAN and/or MSAN builds: * multiprocessing tests * test___all__ * test_concurrent_futures * test_decimal * test_peg_generator * test_tools (cherry picked from commit 9204bb7) Co-authored-by: Pablo Galindo Salgado <[email protected]>
vstinner
added a commit
that referenced
this pull request
Mar 2, 2022
…H-31634) (GH-31644) * Refactor sanitiser skip tests into test.support (GH-30889) * Refactor sanitizer skip tests into test.support (cherry picked from commit b1cb843) * Add skips to crashing tests under sanitizers instead of manually skipping them (GH-30897) (cherry picked from commit a275053) * bpo-46633: Skip tests on ASAN and/or MSAN builds (GH-31632) Skip tests on ASAN and/or MSAN builds: * multiprocessing tests * test___all__ * test_concurrent_futures * test_decimal * test_peg_generator * test_tools (cherry picked from commit 9204bb7) Co-authored-by: Pablo Galindo Salgado <[email protected]> (cherry picked from commit 9326445)
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…) (pythonGH-31634) (pythonGH-31644) * Refactor sanitiser skip tests into test.support (pythonGH-30889) * Refactor sanitizer skip tests into test.support (cherry picked from commit b1cb843) * Add skips to crashing tests under sanitizers instead of manually skipping them (pythonGH-30897) (cherry picked from commit a275053) * bpo-46633: Skip tests on ASAN and/or MSAN builds (pythonGH-31632) Skip tests on ASAN and/or MSAN builds: * multiprocessing tests * test___all__ * test_concurrent_futures * test_decimal * test_peg_generator * test_tools (cherry picked from commit 9204bb7) Co-authored-by: Pablo Galindo Salgado <[email protected]> (cherry picked from commit 9326445)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
No description provided.