Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Add security tag to cpp/return-stack-allocated-memory #7718

Conversation

@MathiasVP
Copy link
Contributor

@MathiasVP MathiasVP commented Jan 24, 2022

The query was rewritten to be more robust in #7682 and #7701 removed all of the FPs that I've seen on LGTM, so I think this query is ready to go into the Code Scanning suite.

This will make the results of cpp/return-stack-allocated-memory show up by default.

Before we merge this I'll run a DCA to make sure we don't get any unintended IR re-evaluations.

@MathiasVP MathiasVP added the C++ label Jan 24, 2022
@MathiasVP MathiasVP requested a review from as a code owner Jan 24, 2022
Copy link
Contributor

@rdmarsh2 rdmarsh2 left a comment

DCA looks good

@rdmarsh2 rdmarsh2 merged commit 6d3381c into github:main Jan 24, 2022
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants