-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Java: Remove some JNDI Injection sinks #7702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java: Remove some JNDI Injection sinks #7702
Conversation
Click to show differences in coveragejavaGenerated file changes for java
- `Spring <https://spring.io/>`_,``org.springframework.*``,29,472,91,,,,19,14,,29
+ `Spring <https://spring.io/>`_,``org.springframework.*``,29,472,96,,,,19,14,,29
- Totals,,182,6212,1419,106,6,10,107,33,1,81
+ Totals,,182,6212,1424,106,6,10,107,33,1,81
- org.springframework.ldap,42,,,,,,,,,,28,14,,,,,,,,,,,,,,,,,
+ org.springframework.ldap,47,,,,,,,,,,33,14,,,,,,,,,,,,,,,,, |
Add tests and stubs
c1dfba4 to
78d7e53
Compare
Click to show differences in coveragejavaGenerated file changes for java
- `Spring <https://spring.io/>`_,``org.springframework.*``,29,472,91,,,,19,14,,29
+ `Spring <https://spring.io/>`_,``org.springframework.*``,29,472,96,,,,19,14,,29
- Totals,,182,6212,1419,106,6,10,107,33,1,81
+ Totals,,182,6212,1424,106,6,10,107,33,1,81
- org.springframework.ldap,42,,,,,,,,,,28,14,,,,,,,,,,,,,,,,,
+ org.springframework.ldap,47,,,,,,,,,,33,14,,,,,,,,,,,,,,,,, |
aschackmull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM at a glance, but the test fails.
Click to show differences in coveragejavaGenerated file changes for java
- `Spring <https://spring.io/>`_,``org.springframework.*``,29,472,91,,,,19,14,,29
+ `Spring <https://spring.io/>`_,``org.springframework.*``,29,472,96,,,,19,14,,29
- Totals,,182,6212,1419,106,6,10,107,33,1,81
+ Totals,,182,6212,1424,106,6,10,107,33,1,81
- org.springframework.ldap,42,,,,,,,,,,28,14,,,,,,,,,,,,,,,,,
+ org.springframework.ldap,47,,,,,,,,,,33,14,,,,,,,,,,,,,,,,, |
|
@aschackmull stubs needed fixing. All checks are now green. |
Removes JNDI Injection sinks that were causing false positives:
LdapOperations.lookupmethods receiving anAttributesMapperparameter don't actually callDirContext.lookup, but onlyDirContext.getAttributes. Also, adds tests and stubs for these cases.Fixes #7699.