Skip to content

small refactorizations across CodeQL #7684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yoff merged 4 commits into from
Jan 21, 2022
Merged

small refactorizations across CodeQL #7684

yoff merged 4 commits into from
Jan 21, 2022

Conversation

@erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jan 20, 2022 •
edited
Loading

I applied all my automatic patches to all the code in github/codeql.
The result wasn't overwhelming, so I opened this PR with the result.

This PR reduce the number code-scanning warnings by about 200.

(Patch-query)

@erik-krogh erik-krogh added the no-change-note-required This PR does not need a change note label Jan 20, 2022
smowton
smowton approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 👍

@erik-krogh erik-krogh changed the title patches small refactorizations across CodeQL Jan 21, 2022
@erik-krogh erik-krogh marked this pull request as ready for review January 21, 2022 13:06
@erik-krogh erik-krogh requested review from a team as code owners January 21, 2022 13:06
hvitved
hvitved reviewed Jan 21, 2022
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C# and Ruby 👍

esbena
esbena reviewed Jan 21, 2022
View reviewed changes
Copy link
Contributor

@esbena esbena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JS 👍

yoff
yoff approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@yoff yoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yoff yoff merged commit a77a6ec into github:main Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esbena esbena esbena left review comments

@hvitved hvitved hvitved left review comments

@smowton smowton smowton approved these changes

@yoff yoff yoff approved these changes

@MathiasVP MathiasVP MathiasVP approved these changes

@aschackmull aschackmull aschackmull approved these changes

Assignees

No one assigned

Labels

C# C++ documentation Java JS no-change-note-required This PR does not need a change note Python Ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@erik-krogh @smowton @yoff @esbena @hvitved @MathiasVP @aschackmull