Skip to content

C#: Fix false positive alert for shadowing on record types. #7628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michaelnebel merged 3 commits into from
Jan 19, 2022
Merged

C#: Fix false positive alert for shadowing on record types. #7628

michaelnebel merged 3 commits into from
Jan 19, 2022

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 18, 2022 •
edited
Loading

When defining a record type, the compiler generates a Deconstruct method on the class or struct representing the record type.
This method has out parameters with the same name as property accessors.
In this PR we add this exception to the rule that identifies bad practices related to shadowing.

@michaelnebel michaelnebel requested a review from a team as a code owner January 18, 2022 11:53
@github-actions github-actions bot added the C# label Jan 18, 2022
@michaelnebel
Copy link
Contributor Author

michaelnebel commented Jan 18, 2022 •
edited
Loading

Closes #7609

hvitved
hvitved previously approved these changes Jan 18, 2022
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@michaelnebel michaelnebel added no-change-note-required This PR does not need a change note and removed no-change-note-required This PR does not need a change note labels Jan 18, 2022
@michaelnebel michaelnebel requested a review from hvitved January 18, 2022 14:56
hvitved
hvitved reviewed Jan 18, 2022
View reviewed changes
@michaelnebel michaelnebel requested a review from hvitved January 18, 2022 15:32
hvitved
hvitved previously approved these changes Jan 19, 2022
View reviewed changes
@michaelnebel
Copy link
Contributor Author

michaelnebel commented Jan 19, 2022

Will need to rebase after #7605 is merged.

@hvitved
Copy link
Contributor

hvitved commented Jan 19, 2022 •
edited
Loading

Will need to rebase after #7605 is merged.

Why is that? Got it!

@michaelnebel michaelnebel merged commit 3df3054 into github:main Jan 19, 2022
@michaelnebel michaelnebel deleted the csharp/issue-7609 branch January 19, 2022 11:27
@smowton smowton mentioned this pull request Jan 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C# documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelnebel @hvitved