Skip to content

Conversation

@erik-krogh
Copy link
Contributor

@erik-krogh erik-krogh commented Jan 20, 2022

I've found this pattern during a PR review, but the query finds nothing in github/codeql 🎉

@erik-krogh erik-krogh force-pushed the fieldUnusedInDisjunct branch from 02caab7 to fb011c3 Compare March 9, 2022 10:46
@erik-krogh erik-krogh marked this pull request as ready for review March 9, 2022 11:35
@erik-krogh erik-krogh requested a review from a team as a code owner March 9, 2022 11:35
@github-actions github-actions bot removed the JS label Jun 2, 2022
Copy link
Contributor

@nickrolfe nickrolfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and I see it caught the CP that was fixed in #9157 🚀

@erik-krogh erik-krogh merged commit b24b275 into github:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants