Skip to content

C#: Support for identifying whether a using directive is "global". #7550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
hvitved merged 8 commits into from
Jan 14, 2022
Merged

C#: Support for identifying whether a using directive is "global". #7550

hvitved merged 8 commits into from
Jan 14, 2022

Conversation

@michaelnebel
Copy link
Contributor

@michaelnebel michaelnebel commented Jan 10, 2022 •
edited
Loading

In this PR we

  • Make support for global using statements in the C# extractor (C# 10 feature).
  • Make database upgrade/downgrade scripts.
  • Update the stats file using a DCA run, where some projects uses C# 10 features are included.

@github-actions github-actions bot added the C# label Jan 10, 2022
@michaelnebel michaelnebel marked this pull request as ready for review January 11, 2022 08:08
@michaelnebel michaelnebel requested a review from a team as a code owner January 11, 2022 08:08
@michaelnebel
Copy link
Contributor Author

michaelnebel commented Jan 11, 2022

Setting this for review now in case any changes are required prior to running the DCA job.

@michaelnebel michaelnebel force-pushed the csharp/global-using branch 3 times, most recently from 0272e04 to fc00835 Compare January 12, 2022 10:52
hvitved
hvitved reviewed Jan 13, 2022
View reviewed changes
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see what the performance comparison looks like after adding new stats.

@michaelnebel
Copy link
Contributor Author

michaelnebel commented Jan 13, 2022

Sounds good to me!

michaelnebel and others added 8 commits January 14, 2022 10:10
@michaelnebel
C#: Refactor to re-use code to extract modifier tokens.
6e72f6e
@michaelnebel
C#: Refactor Tuples to use expression body syntax.
e305a8a
@michaelnebel
C#: Add support for the global modifier for using directives.
c118d9b
@michaelnebel
C#: Add test for global using directive.
a1eff16
@michaelnebel
C#: Add database upgrade script for adding the using_global relation.
dcd6a6b
@michaelnebel
C#: Add downgrade script for deleting using_global relation.
f025db0
@hvitved @michaelnebel
C#: Update stats
411d2b2
@hvitved @michaelnebel
C#: Eliminate bad magic optimization
6c20585 
```
[2022-01-14 08:57:14] (253s) Tuple counts for Stmt::getAChild#bbf/3@8dfbc66f after 1m53s:
                      4922010396 ~5%     {3} r1 = JOIN ControlFlowElement::ControlFlowElement::getEnclosingCallable_dispred#ff_10#join_rhs WITH ControlFlowElement::ControlFlowElement::getEnclosingCallable_dispred#ff_10#join_rhs ON FIRST 1 OUTPUT Lhs.1 'cfe', Rhs.1 'cfe', Lhs.0 'c'
                      1597068    ~2%     {3} r2 = JOIN r1 WITH Element::Element::getAChild_dispred#ff ON FIRST 2 OUTPUT Lhs.0 'cfe', Lhs.2 'c', Lhs.1 'result'
                                         return r2
```
@hvitved hvitved merged commit 2ecf0d3 into github:main Jan 14, 2022
@michaelnebel michaelnebel deleted the csharp/global-using branch January 17, 2022 07:48
@michaelnebel michaelnebel mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C#

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelnebel @hvitved