New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
QL-for-QL: Add a redundant aggregate query #7472
Open
erik-krogh
wants to merge
3
commits into
github:main
Choose a base branch
from
erik-krogh:redundant-aggregate
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5e2883f
to
09b2be1
calumgrant
reviewed
Dec 22, 2021
calumgrant
reviewed
Dec 22, 2021
d0ccfd2
to
c870d87
|
I disagree with simplifying the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Inspired by #5160
I haven't fixed the issues identified by this query (I got a patch ready, but I wanted to reduce the scope of the PR).
This query identifies two patterns:
1: A redundant aggregate like:
Can be simplified to:
2: Aggregates that can be simplified to a type-cast:
exists(Type t | t = foo())can be simplified tofoo() instanceof Type.(And
any(Type t | t = foo())can be simplified tofoo().(Type)).Note: an
exists(..)is actually a qualifier and not an aggregate, but I'm unsure what else to call something that is either anexists(..)or anany(..).The text was updated successfully, but these errors were encountered: