Skip to content

Conversation

@tausbn
Copy link
Contributor

@tausbn tausbn commented Jan 3, 2022

See

tausbn/tree-sitter-ql@7253954

for the grammar changes and corresponding test.

@tausbn tausbn requested a review from erik-krogh January 3, 2022 13:18
@erik-krogh
Copy link
Contributor

The workflows didn't recompile the extractor, it just used a cached version.

The cause seems to be that the Cargo.lock file hasn't changed.
I think you need to run a cargo build or something.

@tausbn
Copy link
Contributor Author

tausbn commented Jan 3, 2022

Aha! Thanks. I figured I had forgotten something.

See

tausbn/tree-sitter-ql@7253954

for the grammar changes and corresponding test.
@tausbn tausbn force-pushed the ql-support-trailing-comma-in-set-literals branch from 0cf78e0 to 8845529 Compare January 3, 2022 15:48
Copy link
Contributor

@erik-krogh erik-krogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Lots of fixed consistency issues according to code-scanning 🎉

@tausbn tausbn merged commit ec533c8 into github:main Jan 3, 2022
@tausbn tausbn deleted the ql-support-trailing-comma-in-set-literals branch January 3, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants