Move upgrades into standard library packs #7355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Failing C# tests. Should be working when run against the PR. Here is an attempt at running it: https://github.com/github/semmle-code/actions/runs/1565148791 |
aeisenberg
force-pushed
the
aeisenberg/remove-upgrades
branch
2 times, most recently
from
2037781 to
2b67876
Compare
Move upgrade to new location Remove incorrectly merged files Fix upgrades section
aeisenberg
force-pushed
the
aeisenberg/remove-upgrades
branch
from
2b67876 to
83ceb82
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #7166. This time it is not in a fork.
This PR moves the upgrade scripts for C#, C++, Java, JavaScript, and Python into the corresponding standard library packs (the same pack that contains the dbscheme).
Having upgrades in a separate pack gives us little or no advantage, and increases the overhead of package management. We wind up with the standard library (say, codeql/cpp-all) depending on another library pack (codeql/cpp-upgrades), but the version number of that dependency always needs to be kept in sync with the version number of the upgrade pack. In addition, no other pack for that language would have any reason to declare a dependency on the upgrade pack, so no query pack would ever have a reason to depend on a version of the upgrade pack other than the one that was published at the same time as that version of the library pack. By simply merging the packs we ensure that the right upgrade scripts are always available without having to keep two package versions in sync.
The actual changes were as follows:
<lang>/upgradesto<lang>/ql/lib/upgradesverbatim.upgrades: upgradesproperty to qlpack.yml for each standard library pack.qlpack*.ymlfor upgrade packs.The corresponding internal PR fixes up the build system to handle the change.
Note that Ruby already put its upgrades in its standard library.