Skip to content

Conversation

@chrisjsimpson
Copy link

@chrisjsimpson chrisjsimpson commented Dec 31, 2021

Why:

Remarkably easy to miss that workflow_dispatch is only for the default branch. The warning is already present for repository_dispatch but not for workflow_dispatch.

What's being changed:

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@welcome
Copy link

welcome bot commented Dec 31, 2021

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 31, 2021

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Staging Production What Changed
content/actions/learn-github-actions/events-that-trigger-workflows.md Modified Original

@github-actions github-actions bot temporarily deployed to docs-13559--patch-2 December 31, 2021 20:25 Inactive
@Bbddrr

This comment has been minimized.

@github-actions github-actions bot temporarily deployed to docs-13559--patch-2 January 1, 2022 23:36 Inactive
@ramyaparimi ramyaparimi added actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review labels Jan 3, 2022
@ramyaparimi
Copy link
Contributor

@chrisjsimpson
Thanks so much for opening a PR! I'll get this triaged for review ⚡

Comment on lines +101 to +105
{% note %}

**Note:** This manual event can only run a workflow if the workflow file is on the default branch.

{% endnote %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a "reusable" for this text so that we can keep it consistent across all the different events.

Suggested change
{% note %}
**Note:** This manual event can only run a workflow if the workflow file is on the default branch.
{% endnote %}
{% data reusables.github-actions.branch-requirement %}

Copy link
Contributor

@ethomson ethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for calling this out, @chrisjsimpson - I've suggested a minor change for consistency.

@ramyaparimi ramyaparimi removed the waiting for review Issue/PR is waiting for a writer's review label Jan 26, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2022

A stale label has been added to this pull request because it has been open 7 days with no activity. To keep this PR open, add a comment or push a commit within 3 days.

@github-actions github-actions bot added the stale There is no recent activity on this issue or pull request label Feb 2, 2022
@github-actions github-actions bot closed this Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team stale There is no recent activity on this issue or pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants