C#: Promote existing ad-hoc consistency checks to consistency queries #7469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`x` and `y` in `pair is var (x, y) ? x : null` are now correctly part of `PatternExpr`.
hvitved
force-pushed
the
csharp/promote-adhoc-consistency-checks
branch
from
3eb612b
to
8a62778
tamasvajk
reviewed
Dec 22, 2021
| var child = 0; | ||
| foreach (var arg in initializer.ArgumentList.Arguments) | ||
| { | ||
| Expression.Create(Context, arg.Expression, init, child++); | ||
| } |
There was a problem hiding this comment.
I think the same changes should be applied to the similar cases in:
- Tuple.cs, and
- Initializer.cs.
Maybe it's not possible in all cases to use each of ref, out or in. But in works in the below, and I don't think we extract it:
using System;
public class C {
public void M() {
var i = 1;
new C { [in i] = 42 };
}
public int this[in int i] {
get { return 42; }
set { Console.WriteLine(value); }
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Identified two issues that are fixed on this PR.
The text was updated successfully, but these errors were encountered: