Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add generated artifacts in Mac/ to .gitignore; update copyright #29408

Merged
merged 1 commit into from Nov 4, 2021
Merged

Add generated artifacts in Mac/ to .gitignore; update copyright #29408

merged 1 commit into from Nov 4, 2021

Conversation

@ambv
Copy link
Contributor

@ambv ambv commented Nov 4, 2021

This makes a framework build entirely free of new files that Git considers untracked.
@ambv ambv requested a review from ned-deily Nov 4, 2021
@ambv ambv requested a review from as a code owner Nov 4, 2021
ned-deily
ned-deily approved these changes Nov 4, 2021
View changes
Copy link
Member

@ned-deily ned-deily left a comment

LGTM, thanks!

Loading

@ambv ambv merged commit 3167df1 into python:main Nov 4, 2021
11 checks passed
Loading
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Nov 4, 2021

Thanks @ambv for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

Loading

@ambv ambv deleted the mac-cleanup branch Nov 4, 2021
miss-islington added a commit to miss-islington/cpython that referenced this issue Nov 4, 2021
@ambv @miss-islington
Add generated artifacts in Mac/ to .gitignore; update copyright (pyth…
846c429 
…onGH-29408)

(cherry picked from commit 3167df1)

Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 4, 2021

GH-29409 is a backport of this pull request to the 3.10 branch.

Loading

miss-islington added a commit to miss-islington/cpython that referenced this issue Nov 4, 2021
@ambv @miss-islington
Add generated artifacts in Mac/ to .gitignore; update copyright (pyth…
9477142 
…onGH-29408)

(cherry picked from commit 3167df1)

Co-authored-by: Łukasz Langa <[email protected]>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Nov 4, 2021

GH-29410 is a backport of this pull request to the 3.9 branch.

Loading

ambv added a commit that referenced this issue Nov 4, 2021
@ambv @miss-islington
Add generated artifacts in Mac/ to .gitignore; update copyright (GH-2…
9a4604b 
…9408) (GH-29410)

(cherry picked from commit 3167df1)

Co-authored-by: Łukasz Langa <[email protected]>
ambv added a commit that referenced this issue Nov 4, 2021
@ambv @miss-islington
Add generated artifacts in Mac/ to .gitignore; update copyright (GH-2…
d729c80 
…9408) (GH-29409)

(cherry picked from commit 3167df1)

Co-authored-by: Łukasz Langa <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily

Assignees
No one assigned
Labels
CLA signed skip issue skip news
Projects
None yet
Milestone
No milestone
5 participants
@ambv @miss-islington @bedevere-bot @ned-deily @the-knights-who-say-ni