Data flow: Support hidden parameter/return nodes in subpaths predicate
#6824
+1,389
−583
Conversation
hvitved
force-pushed
the
dataflow/subpath-hidden
branch
3 times, most recently
from
d9f896e
to
9e4fea8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
It is not uncommon to have hidden return nodes. For example, languages that add a single unified return node that joins all syntactic return nodes (to reduce fan-in), probably want to hide such synthetic return nodes. However, the
subpathspredicate does not work with hidden return nodes.This PR lifts that restriction, and instead chooses any predecessor(s) of the hidden return node
hiddenas theretnode insubpaths.retmust not be hidden, and it must be possible to reachhiddenfromretby only going through hidden nodes.Although probably less realistic to happen in practice, a similar logic is implemented for hidden parameters.
Finally, the
subpathspredicate now filters away tuples where eitherargoroutis hidden.The text was updated successfully, but these errors were encountered: