C++: Improvements to cpp/improper-null-termination #6794
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Improvements to
cpp/improper-null-termination, and to a lesser extentcpp/user-controlled-null-termination-tainted.mediumprecisionThe remaining FPs all seem to be related to branching flows, e.g. where a different variable indicates which branch we've been down / whether the string is initialized / null terminated or not. It's possible
StackVariableReachabilityandTaintTrackingalone won't be up to the job and the queries will need a more significant rewrite to fix this. Doing so might allow them to be increased tohighprecision, but they certainly aren't there yet (see https://lgtm.com/query/5264194598604498103/, https://lgtm.com/query/4764927980359278490/).TODO:
precisiontag it will be used more often)The text was updated successfully, but these errors were encountered: