-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update security-severity scores #6080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The distribution of the scores are as follows:
(Golang is in a separate repo and is not included in this PR). |
aschackmull
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a quick look through, this looks like an improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These scores reflect my expectations much better 👍! Like @rdmarsh2, I'm curious about why some of the scores are slightly lowered by this change, though.
(It's not a big deal since none of the drops cause a query to change to a lower category.)
RasmusWL
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 For python
|
Thanks @calumgrant! Is it possible to easily generate an overview like this for us to do an extra sanity check:
This will allow us to check how many things that we previously gave a high severity (i.e., (cc @AlonaHlobina) |
Run using latest changes to the CWE tooling (https://github.com/github/cwe-scores).
The change is that the score is based on the CVE "Base Score" instead of its "Impact score".
The result of this is that the scores map better to the UI concept of (Low/Medium/High/Critical).