Skip to content

Conversation

@calumgrant
Copy link
Contributor

Run using latest changes to the CWE tooling (https://github.com/github/cwe-scores).

The change is that the score is based on the CVE "Base Score" instead of its "Impact score".

The result of this is that the scores map better to the UI concept of (Low/Medium/High/Critical).

@calumgrant
Copy link
Contributor Author

The distribution of the scores are as follows:

Language Low Medium High Critical
All 9 144 332 138
C# 1 22 64 24
C++ 2 13 83 33
Golang 0 13 22 10
Java 0 60 95 46
JavaScript 6 37 56 26
Python 0 12 34 9

(Golang is in a separate repo and is not included in this PR).

@calumgrant calumgrant marked this pull request as ready for review June 15, 2021 14:14
@calumgrant calumgrant requested review from a team as code owners June 15, 2021 14:14
@calumgrant calumgrant added the no-change-note-required This PR does not need a change note label Jun 15, 2021
Copy link
Contributor

@aschackmull aschackmull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From a quick look through, this looks like an improvement.

Copy link
Contributor

@MathiasVP MathiasVP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These scores reflect my expectations much better 👍! Like @rdmarsh2, I'm curious about why some of the scores are slightly lowered by this change, though.
(It's not a big deal since none of the drops cause a query to change to a lower category.)

Copy link
Member

@RasmusWL RasmusWL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 For python

@sj
Copy link
Collaborator

sj commented Jun 16, 2021

Thanks @calumgrant! Is it possible to easily generate an overview like this for us to do an extra sanity check:

security-severity \ severity recommendation warning error
low 1 2 3
medium 4 5 6
high 7 8 9
critical 10 11 12

This will allow us to check how many things that we previously gave a high severity (i.e., error) actually end up having a low security-severity.

(cc @AlonaHlobina)

@calumgrant calumgrant merged commit 32f6a46 into main Jun 18, 2021
@calumgrant calumgrant deleted the calumgrant/security-severities branch June 18, 2021 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants