Skip to content

Bring compiler docs up to speed with Python 3.10 #706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 9 commits into from
May 24, 2021
Merged

Bring compiler docs up to speed with Python 3.10 #706

pablogsal merged 9 commits into from
May 24, 2021

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented May 23, 2021 •
edited
Loading

Fixes #678.

  • Updated renamed functions and files in 3.10.
  • Small note for Windows build.bat.
  • Updated compiler docs with new PEG parser and typed ASDL sequences.

@Fidget-Spinner Fidget-Spinner marked this pull request as draft May 23, 2021 14:32
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented May 23, 2021 •
edited
Loading

Reviews are welcome and very appreciated -- I'm no expert in the parser.

@Fidget-Spinner Fidget-Spinner marked this pull request as ready for review May 23, 2021 15:01
@Fidget-Spinner Fidget-Spinner requested a review from pablogsal May 23, 2021 16:13
pablogsal
pablogsal reviewed May 23, 2021
View reviewed changes
pablogsal
pablogsal reviewed May 23, 2021
View reviewed changes
pablogsal
pablogsal reviewed May 23, 2021
View reviewed changes
pablogsal
pablogsal reviewed May 23, 2021
View reviewed changes
lysnikolaou
lysnikolaou reviewed May 24, 2021
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this @Fidget-Spinner! I left some minor comments.

pablogsal
pablogsal reviewed May 24, 2021
View reviewed changes
compiler.rst
asdl_c.py
"Generate C code from an ASDL description." Generates
:file:`Python/Python-ast.c` and :file:`Include/Python-ast.h`.
:file:`Python/Python-ast.c` and :file:`Include/Internal/pycore_ast.h`.
Copy link
Member

@pablogsal pablogsal May 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like these descriptions but the header files get refactored quite a lot (specially the ast ones) so I am a bit scared that this gets out of date, but is still an improvement so I say: let's merge it.

@pablogsal
Copy link
Member

pablogsal commented May 24, 2021

Fantastic job @Fidget-Spinner 🎉

@pablogsal pablogsal merged commit d84dd7a into python:master May 24, 2021
@Fidget-Spinner
Copy link
Member Author

Fidget-Spinner commented May 24, 2021

Pablo and Lysandros, thank you both for the helpful reviews! This PR has improved greatly thanks to your feedback and I've also learnt a lot.

Re:

I like these descriptions but the header files get refactored quite a lot (specially the ast ones) so I am a bit scared that this gets out of date, but is still an improvement so I say: let's merge it.

Yup I agree.

@Fidget-Spinner Fidget-Spinner deleted the pep617-compiler branch May 24, 2021 23:40
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
@Fidget-Spinner
Bring compiler docs up to speed with Python 3.10 (python#706)
970b03e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

@lysnikolaou lysnikolaou lysnikolaou left review comments

Assignees

No one assigned

Labels

CLA signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update compiler docs with the new parser changes

4 participants

@Fidget-Spinner @pablogsal @lysnikolaou @the-knights-who-say-ni