JS: add "uid" (and friends) as maybe being sensitive account info #5897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
no-change-note-required
esbena
approved these changes
May 17, 2021
Contributor
esbena
left a comment
esbena
left a comment
There was a problem hiding this comment.
At first I thought this was a bit too ad hoc and would be too noisy, and that other queries that js/insecure-randomness also should be evaluated.
But then I noticed that we already treated the similar puid as sensitive, so I suppose this change is benign in practice.
RasmusWL
approved these changes
May 17, 2021
Member
RasmusWL
left a comment
RasmusWL
left a comment
There was a problem hiding this comment.
No objections on the Python part 👍
erik-krogh
removed
the
Awaiting evaluation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TP/TN for CVE-2020-7660
An LGTM showing which variables are now treated as sensitive reveals some FPs.
(Like this
getUidmethod in bootstrap).But generally I think the new results look good.
An evaluation shows some noisy performance. And about the same amount of FPs as the above LGTM run.