➜

This issue tracker will soon become read-only and move to GitHub.
For a smoother transition, remember to log in and link your GitHub username to your profile.
For more information, see this post about the migration.

classification
Title: zipfile: Deduplicate ZipExtFile code for init and resetting when seeking
Type: enhancement Stage: patch review
Components: Library (Lib) Versions: Python 3.11, Python 3.10
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: Nosy List: dhillier, serhiy.storchaka
Priority: normal Keywords: patch

Created on 2021-05-14 04:13 by dhillier, last changed 2021-05-14 04:33 by dhillier.

Pull Requests
URL Status Linked Edit
PR 26116 open dhillier, 2021-05-14 04:33
Messages (1)
msg393619 - (view) Author: Daniel Hillier (dhillier) * Date: 2021-05-14 04:13 
Integrating a refactor suggested in https://bugs.python.org/issue38334

The logic for preparing a ZipExtFile for reading (setting CRC state, read positions, etc) is currently in two locations: first initialisation and when seeking back to the start of a file.

This change moves the logic into the method `ZipExtFile.init_read()`
History
Date User Action Args
2021-05-14 04:33:18dhilliersetkeywords: + patch
stage: patch review
pull_requests: + pull_request24761
2021-05-14 04:13:13dhilliercreate