Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix id of 'Internet Message Format' RFC in email doc #24137

Merged
merged 1 commit into from Apr 26, 2021
Merged

Fix id of 'Internet Message Format' RFC in email doc #24137

merged 1 commit into from Apr 26, 2021

Conversation

dlax
Copy link
Contributor

@dlax dlax commented Jan 6, 2021

Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5232 (https://tools.ietf.org/html/rfc5322).

(The typo probably comes from commit 29d1bc0#diff-7728cd0eb5e471a8d52c0850e26560351f50ec6cb59d03bd5646bf492d80eb24 in which the ID of
this RFC got updated from the obsolete 2822.)

@dlax dlax requested a review from a team as a code owner Jan 6, 2021
@the-knights-who-say-ni
Copy link

the-knights-who-say-ni commented Jan 6, 2021

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@dlax

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Jan 6, 2021
serverwentdown
serverwentdown suggested changes Feb 11, 2021
View changes
Copy link
Contributor

@serverwentdown serverwentdown left a comment •
edited

Wow, this typo has been around for 5 years. Nice find!

There is also one more occurrence in email.compat32-message.rst, that should probably be updated too.

Doc/library/email.rst Outdated Show resolved Hide resolved
@dlax @serverwentdown
Fix id of 'Internet Message Format' RFC in email doc
55a20a7 
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322).

(The typo probably comes from commit 29d1bc0 in which the ID of
this RFC got updated from the obsolete 2822.)

Co-authored-by: Ambrose Chua <[email protected]>
serverwentdown
serverwentdown approved these changes Feb 11, 2021
View changes
Copy link
Contributor

@serverwentdown serverwentdown left a comment

LGTM, now links to the correct RFC.

@github-actions
Copy link

github-actions bot commented Mar 14, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Mar 14, 2021
@orsenthil orsenthil merged commit cb5c802 into python:master Apr 26, 2021
3 checks passed
@miss-islington
Copy link
Contributor

miss-islington commented Apr 26, 2021

Thanks @dlax for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
@dlax @miss-islington
Fix id of 'Internet Message Format' RFC in email doc (pythonGH-24137)
e5d17ca 
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322).

(The typo probably comes from commit 29d1bc0 in which the ID of
this RFC got updated from the obsolete 2822.)

Co-authored-by: Ambrose Chua <[email protected]>
(cherry picked from commit cb5c802)

Co-authored-by: Denis Laxalde <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Apr 26, 2021

GH-25613 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
@dlax @miss-islington
Fix id of 'Internet Message Format' RFC in email doc (pythonGH-24137)
9dbc9e8 
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322).

(The typo probably comes from commit 29d1bc0 in which the ID of
this RFC got updated from the obsolete 2822.)

Co-authored-by: Ambrose Chua <[email protected]>
(cherry picked from commit cb5c802)

Co-authored-by: Denis Laxalde <[email protected]>
@bedevere-bot
Copy link

bedevere-bot commented Apr 26, 2021

GH-25614 is a backport of this pull request to the 3.8 branch.

@dlax dlax deleted the docs/fix-email-rfc branch Apr 26, 2021
kreathon pushed a commit to kreathon/cpython that referenced this pull request May 2, 2021
@dlax @serverwentdown @kreathon
Fix id of 'Internet Message Format' RFC in email doc (pythonGH-24137)
a475270 
Previous ID (5233) refers to "Sieve Email Filtering: Subaddress
Extension". It seems that the actual reference should be "Internet
Message Format" RFC 5322 (https://tools.ietf.org/html/rfc5322).

(The typo probably comes from commit 29d1bc0 in which the ID of
this RFC got updated from the obsolete 2822.)

Co-authored-by: Ambrose Chua <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil

@serverwentdown serverwentdown

@python/email-team email-team

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip issue skip news stale Stale PR or inactive for long period of time.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@dlax @the-knights-who-say-ni @miss-islington @bedevere-bot @orsenthil @serverwentdown @tirkarthi