Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing quotes in pydoc in smtplib.py #22292

Merged
merged 1 commit into from Apr 26, 2021
Merged

Fixing quotes in pydoc in smtplib.py #22292

merged 1 commit into from Apr 26, 2021

Conversation

@uy-rrodriguez
Copy link
Contributor

@uy-rrodriguez uy-rrodriguez commented Sep 17, 2020

Fixing minor mistake in the quotes around a couple of arguments for the constructor of the class SMTP, in smtplib.py.

Fixing minor mistake in the quotes around a couple of arguments for the constructor of the class `SMTP`, in smtplib.py.
@uy-rrodriguez uy-rrodriguez requested a review from python/email-team as a code owner Sep 17, 2020
@the-knights-who-say-ni
Copy link

@the-knights-who-say-ni the-knights-who-say-ni commented Sep 17, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@uy-rrodriguez

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@orsenthil orsenthil merged commit b3dec6f into python:master Apr 26, 2021
9 checks passed
9 checks passed
Check for source changes
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu Ubuntu
Details
Azure Pipelines PR #20200917.12 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue report skipped
bedevere/news "skip news" label found
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 26, 2021

Thanks @uy-rrodriguez for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
Fixing minor mistake in the quotes around a couple of arguments for the constructor of the class `SMTP`, in smtplib.py.
(cherry picked from commit b3dec6f)

Co-authored-by: uy-rrodriguez <[email protected]>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 26, 2021

GH-25615 is a backport of this pull request to the 3.9 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 26, 2021

GH-25616 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit to miss-islington/cpython that referenced this pull request Apr 26, 2021
Fixing minor mistake in the quotes around a couple of arguments for the constructor of the class `SMTP`, in smtplib.py.
(cherry picked from commit b3dec6f)

Co-authored-by: uy-rrodriguez <[email protected]>
orsenthil pushed a commit that referenced this pull request Apr 26, 2021
Fixing minor mistake in the quotes around a couple of arguments for the constructor of the class `SMTP`, in smtplib.py.
(cherry picked from commit b3dec6f)

Co-authored-by: uy-rrodriguez <[email protected]>
orsenthil pushed a commit that referenced this pull request Apr 26, 2021
Fixing minor mistake in the quotes around a couple of arguments for the constructor of the class `SMTP`, in smtplib.py.
(cherry picked from commit b3dec6f)

Co-authored-by: uy-rrodriguez <[email protected]>
@uy-rrodriguez uy-rrodriguez deleted the uy-rrodriguez:patch-1 branch Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants