bpo-43879: Add native_thread_id field to PyThreadState #25458
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
Hi...I think this change requires a news entry. |
P403n1x87
force-pushed the
P403n1x87:bpo-43879-add-native-thread-id-field
branch
from
d815ed5
to
70380bb
| @@ -106,6 +106,7 @@ struct _ts { | |||
|
|
|||
| PyObject *async_exc; /* Asynchronous exception to raise */ | |||
| unsigned long thread_id; /* Thread id where this tstate was created */ | |||
| unsigned long native_thread_id; /* Native thread id, when available */ | |||
vstinner
May 14, 2021
Member
Please document the behavior when PyThread_get_thread_native_id() is not available (field set to 0 if I understand correctly). How can a dev know if the function is available? Is it ok to check if the PY_HAVE_THREAD_NATIVE_ID macro is defined?
The comment doesn't mention "where this tstate was created".
P403n1x87
force-pushed the
P403n1x87:bpo-43879-add-native-thread-id-field
branch
from
70380bb
to
e507b83
vstinner
merged commit 90a6c07
into
python:main
|
Merged, thank you. |
https://bugs.python.org/issue43879