C#: A few minor SSA performance tweaks #5715
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
csharp/ssa/perf-tweaks
branch
from
5673998 to
9128ec7
Compare
tamasvajk
reviewed
Apr 21, 2021
Contributor
tamasvajk
left a comment
tamasvajk
left a comment
There was a problem hiding this comment.
The diff job has failed.
| predicate defAdjacentRead(Definition def, BasicBlock bb1, BasicBlock bb2, int i2) { | ||
| varBlockReaches(def, bb1, bb2) and | ||
| ssaRefRank(bb2, i2, def.getSourceVariable(), SsaRead()) = 1 and | ||
| variableRead(bb2, i2, _, _) |
Contributor
There was a problem hiding this comment.
Why was variableRead(bb2, i2, _, _) removed?
Contributor
Author
There was a problem hiding this comment.
Because it is implied by ssaRefRank(bb2, i2, def.getSourceVariable(), SsaRead()), so it was simply redundant.
Contributor
Author
Sorry, I forgot to update the description with the new job: https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/1019/ |
tamasvajk
approved these changes
Apr 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jenkins.internal.semmle.com/job/Changes/job/CSharp-Differences/1015/