Java: Add models for StrBuilder's fluent methods #5383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
changed the title
Contributor
|
Could you move 9b8e0fc into its own PR? |
Contributor
Author
smowton
force-pushed
the
smowton/feature/strbuilder-fluent-methods
branch
from
e82c66d to
42b63a6
Compare
Contributor
Author
|
@aschackmull rebased on |
aschackmull
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #5372 -- only review the last 3 commits here.This includes adding a hook at the top of additionalLocalTaintStep to take(done in #5413)inX -taint-> inY and inY -value-> outZto implyinX -taint-> outZand similarlyinX -taint-> outZ and inY -value-> outZimpliesinX -taint-> inY. I did this at the top level because this makes the behaviour uniform across all the different ways a MethodAccess can gain a taint step that crosses the callsite; testing onelasticsearchshowed a reasonable join order, so the additional taint edges were acceptably cheap to compute (<1s to compute the additional edges predicate vs. a total runtime of around 15 minutes).