Skip to content

/ cpython

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-43345: Enhance TypedDict documentation. #24668

Merged
merged 2 commits into from Feb 28, 2021
Merged

bpo-43345: Enhance TypedDict documentation. #24668

merged 2 commits into from Feb 28, 2021
+13 −12

Conversation

@pbryan
Copy link
Contributor

@pbryan pbryan commented Feb 28, 2021 •
edited by bedevere-bot

https://bugs.python.org/issue43345
@pbryan
bpo-43345: Enhance TypedDict documentation.
Loading status checks…
ff09f8d
@pbryan pbryan requested review from gvanrossum and ilevkivskyi as code owners Feb 28, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Feb 28, 2021
@bedevere-bot bedevere-bot added type-documentation awaiting review labels Feb 28, 2021
@gvanrossum
gvanrossum approved these changes Feb 28, 2021
View changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Thanks!
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Feb 28, 2021
@gvanrossum gvanrossum added the skip news label Feb 28, 2021
@gvanrossum
gvanrossum reviewed Feb 28, 2021
View changes
Doc/library/typing.rst Outdated Show resolved Hide resolved
@gvanrossum
Fix whitespace
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5aa0ed2
@Fidget-Spinner
Fidget-Spinner approved these changes Feb 28, 2021
View changes
Copy link
Contributor

@Fidget-Spinner Fidget-Spinner left a comment

LGTM, thanks for fixing the grammatical/reST formatting issues too.
@gvanrossum gvanrossum merged commit 1e3c682 into python:master Feb 28, 2021
11 checks passed
11 checks passed
Docs
Details
Check for source changes
Details
Check if generated files are up to date
Details
Windows (x86)
Details
Windows (x64)
Details
macOS
Details
Ubuntu
Details
Azure Pipelines PR #20210228.11 succeeded
Details
Travis CI - Pull Request Build Passed
Details
bedevere/issue-number Issue number 43345 found
Details
bedevere/news "skip news" label found
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Feb 28, 2021

@gvanrossum: Please replace # with GH- in the commit message next time. Thanks!
@bedevere-bot bedevere-bot removed the awaiting merge label Feb 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum

@Fidget-Spinner Fidget-Spinner

@ilevkivskyi ilevkivskyi

Assignees
No one assigned
Labels
CLA signed skip news type-documentation
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
@pbryan @bedevere-bot @gvanrossum @Fidget-Spinner @the-knights-who-say-ni