Python: Enclosing callable for synthetic arguments #4757
Conversation
RasmusWL
left a comment
RasmusWL
left a comment
There was a problem hiding this comment.
Would it be possible to see this change in action with some tests? 😊
|
Yes, that should be fairly easy. I split it out because my endeavours to fix all the inconsistencies I could find turned out to be a longer process. I should add a small function call to the inconsistency test files for each type of synthetic argument. |
yoff
force-pushed
the
python-dataflow-synthetic-callables
branch
from
8f90f31 to
0629d3e
Compare
|
Added tests, rearranged history and made tests be run after each commit, and force-pushed. I realize that it would be even better to enable the three fixes on at a time and see the failures disappear, let me know if you want that. It also exposed a new failure :-) |
RasmusWL
left a comment
RasmusWL
left a comment
There was a problem hiding this comment.
Nice 👍. Thanks for rearranging history to make things easy. For this case, it's simple enough that I don't need separate commits, but it's good to keep in mind for more tricky cases 👍 (that is, if each fix needed 100 lines of QL code, having 3 separate commits would be nice)
2 participants
We had consistency failures because synthetic arguments do not have enclosing callables.