Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to a system font stack? #55

Open
pradyunsg opened this issue Sep 16, 2020 · 5 comments
Open

Switch to a system font stack? #55

pradyunsg opened this issue Sep 16, 2020 · 5 comments

Comments

@pradyunsg
Copy link
Contributor

@pradyunsg pradyunsg commented Sep 16, 2020

xref: pandas-dev/pydata-sphinx-theme#247

Would a PR switching this theme to system fonts as per https://systemfontstack.com, be acceptable?

@Mariatta
Copy link
Member

@Mariatta Mariatta commented Sep 16, 2020

Is this the same issue as #54 ?

@pradyunsg
Copy link
Contributor Author

@pradyunsg pradyunsg commented Sep 17, 2020

No. That PR changes this theme to use font-family: Arial, sans-serif to work around a Chrome bug.

This one is suggesting we change to something like: font-family: -apple-system, BlinkMacSystemFont, avenir next, avenir, helvetica neue, helvetica, Ubuntu, roboto, noto, segoe ui, arial, sans-serif; instead, which is a strict superset.

The reasoning why we might want to use such a set of fonts, is presented pretty well on the aforementioned https://systemfontstack.com website. :)

@hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 28, 2020

Might this also fix python/devguide#581?

@pradyunsg
Copy link
Contributor Author

@pradyunsg pradyunsg commented Sep 28, 2020

That's because the font-stack is monospace, sans-serif and should instead be monospace, monospace because of a Chrome bug. 🤷🏽

If a PR is welcome, we should probably change the monospace font stack too (there's an example in the link provided, so... that should fix it).

@hugovk
Copy link
Contributor

@hugovk hugovk commented Sep 28, 2020

That's because the font-stack is monospace, sans-serif and should instead be monospace, monospace because of a Chrome bug. 🤷🏽

Oh! Here's more info on it: https://stackoverflow.com/a/36540436/724176

That's right: two monospace keywords at the end of the font stack. Nobody knows why this works; it just does.

It also links to a 2010 blogpost about it, and it's not going away anytime soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.