Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Update backport instructions #178
Merged
Conversation
Remove the part about merging into master. Remove the part about prefixing the PR title with `X.Y`, cherry_picker.py already does this. Closes #173
committing.rst
Outdated
| @@ -408,45 +408,25 @@ new features. The other branches only receive bug fixes or security fixes. | |||
|
|
|||
| .. _branch-merge: | |||
|
|
|||
| Backporting changes to Python 3.6 (or older version) | |||
| ---------------------------------------------------- | |||
| Backporting Changes to Older Version | |||
|
Thanks :) Updated. |
|
I think the part about prefixing PR title should stay for now. Not every core dev use cherry_picker.py yet :) |
|
A reasonable comment during the transition @berkerpeksag. Perhaps adding a small note about prefixing the PR title and marking it "legacy process" and the cherry_picker.py as the "preferred process". @Mariatta thoughts? |
|
Sounds reasonable :) I'm reviewing the other PR now, and will add back the PR prefix after. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Remove the part about merging into master.
Remove the part about prefixing the PR title with
X.Y, cherry_picker.py already does this.Closes #173