Skip to content

/ devguide

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add git config alias for devguide #458

Open
eamanu opened this issue Feb 6, 2019 · 6 comments
Open

Add git config alias for devguide #458

eamanu opened this issue Feb 6, 2019 · 6 comments

Comments

@eamanu
Copy link
Contributor

@eamanu eamanu commented Feb 6, 2019

Hello everyboy!

I am not sure if here is the appropriate place to this issue. Sorry if not.

On gitbootcamp.rst there is a recommendation to made easy the creation of a branch for PR to test it. I am talking about this:

$ git config --global alias.pr '!sh -c "git fetch upstream pull/${1}/head:pr_${1} && git checkout pr_${1}" -'

What about if is added something similar for maintain updated the CPython repo. I am thinking about something have (like result)

$ git update

To avoid:

$ git checkout master
$ git pull origin master
$ git pull upstream master
$ git push origin master

What do you think about that?

Thanks!
@Mariatta
Copy link
Member

@Mariatta Mariatta commented Feb 6, 2019

GitMate.io thinks possibly related issues are #61 (devguide-git bot), #8 (Add Quick Start: Communications section to devguide), #9 (Add tips for effective online communication to devguide), #217 (Quoting for config alias.pr), and #7 (Add a Sprints organization/preparation section to devguide).
@eamanu eamanu mentioned this issue Feb 7, 2019
Merged
@dorothykiz1
Copy link

@dorothykiz1 dorothykiz1 commented Feb 20, 2019

Hello @eamanu and @Mariatta i would like to work on this issue
@asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Feb 20, 2019

Do you need to update your local master copy?
If the master is tracked against upstream and git checkout master && git pull fetches upstream -- there is no need to keep your local (origin) master up to date.
Actually, you can even remove the branch -- everything still works fine.
@eamanu
Copy link
Contributor Author

@eamanu eamanu commented Feb 21, 2019 •
edited

Hi @asvetlov,

Thanks for you response

Do you need to update your local master copy?

hmmm I think yes. Because this way you can create a branch from master to make the PR. If you have an old master branch maybe when you made the PR this can have some conflicts. This is for local (your computer) copy.

Maybe could not be necessary have and updated copy on my own cpython fork (master branch) on Gihub, but if you follow the devguide, this mentions on https://devguide.python.org/gitbootcamp/#syncing-with-upstream the push to origin master.
@eamanu
Copy link
Contributor Author

@eamanu eamanu commented Feb 21, 2019

For that reason I create the alias.
@matrixise
Copy link
Member

@matrixise matrixise commented Feb 21, 2019 •
edited

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants
@matrixise @asvetlov @Mariatta @eamanu @dorothykiz1
You can’t perform that action at this time.