JS: Make SourceNode::Range non-recursive and make strings SourceNodes #4772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-schaefer
previously approved these changes
Dec 3, 2020
Contributor
max-schaefer
left a comment
max-schaefer
left a comment
There was a problem hiding this comment.
One minor suggestion.
I'd be happy to accept the (apparently minor) performance penalty.
| private class NodeModuleSourcesNodes extends DataFlow::SourceNode::Range { | ||
| NodeModuleSourcesNodes() { | ||
| exists(NodeModule m | | ||
| this = DataFlow::ssaDefinitionNode(SSA::implicitInit([m.getModuleVariable(), m.getExportsVariable()])) |
Contributor
There was a problem hiding this comment.
Would it be worth binding the variable to a field and exposing it through a getter? Then we could use that getter in the charpred of {Module,Exports}VarNode to avoid some duplication.
asgerf
force-pushed
the
js/source-node-tweaks
branch
from
384297d to
44b9b62
Compare
Contributor
Author
|
Superseded by #5499 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evaluation (internal link) shows a minor slow down due to optimizer wobbles, but it has been observed to help with the BDD node limit in some cases.