Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upGitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
I found an error in one of the algorithms, fixed it, and tried to make a pull request. However I already have a previous pr open so I'm unable to make another one. Should i just wait, or close my earlier one?
Also I noticed your conversation about rejecting prs without doctests which makes sense. In this case, the error I've fixed is in a file that I think needs quite a few more changes, and it doesn't yet have doctests included. However, I wanted my first pr for this file to be just a simple fixing of the error. Adding doctests will unfortunately be a little more complicated since the original code writer added a lot of print statements within the functions.