Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Algorithm #3953

Open
maldz3 opened this issue Nov 25, 2020 · 0 comments
Open

Error in Algorithm #3953

maldz3 opened this issue Nov 25, 2020 · 0 comments

Comments

@maldz3
Copy link

@maldz3 maldz3 commented Nov 25, 2020

I found an error in one of the algorithms, fixed it, and tried to make a pull request. However I already have a previous pr open so I'm unable to make another one. Should i just wait, or close my earlier one?

Also I noticed your conversation about rejecting prs without doctests which makes sense. In this case, the error I've fixed is in a file that I think needs quite a few more changes, and it doesn't yet have doctests included. However, I wanted my first pr for this file to be just a simple fixing of the error. Adding doctests will unfortunately be a little more complicated since the original code writer added a lot of print statements within the functions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.