Skip to content

/ python3statement.github.io

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bokeh to the list #191

Merged
merged 1 commit into from Apr 8, 2019
Merged

Add Bokeh to the list #191

merged 1 commit into from Apr 8, 2019

Conversation

@brettcannon
Copy link
Contributor

@brettcannon brettcannon commented Apr 5, 2019

Dropping support in the second half of 2019.
@brettcannon
Add Bokeh to the list
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
9105c97 
Dropping support in the second half of 2019.
@brettcannon
Copy link
Contributor Author

@brettcannon brettcannon commented Apr 5, 2019

/cc @bryevdv
@Carreau
Copy link
Member

@Carreau Carreau commented Apr 5, 2019

That's awesome ! I guess you cold put it in the sections with the logo. Bokeh has a nice logo.

Don't forget to set the python_requires metadata in setup.py

I'll wait for @bryevdv +1.
@bryevdv
Copy link
Contributor

@bryevdv bryevdv commented Apr 5, 2019

+1 ! Thanks @brettcannon
@brettcannon
Copy link
Contributor Author

@brettcannon brettcannon commented Apr 6, 2019

I expect @bryevdv or someone will eventually add the logo, but I was talking with Bryan about this in a call and so doing the edit immediately in the GitHub web UI was too easy to not just do it. 😄
@bryevdv
Copy link
Contributor

@bryevdv bryevdv commented Apr 8, 2019

Not sure if it's easier to make a new PR for the logo or continue here. In case its the latter, here is the logo:

logo
@Carreau
Copy link
Member

@Carreau Carreau commented Apr 8, 2019

Merging for now I'll add the logo later.
@Carreau Carreau merged commit 1b5e895 into python3statement:master Apr 8, 2019
1 check passed
1 check passed
deploy/netlify Deploy preview ready!
Details
@Carreau
Copy link
Member

@Carreau Carreau commented Apr 8, 2019

Thansk !
@Carreau Carreau mentioned this pull request Apr 8, 2019
Closed
@brettcannon brettcannon deleted the brettcannon:patch-7 branch Apr 8, 2019
@CAM-Gerlach CAM-Gerlach mentioned this pull request May 3, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@brettcannon @Carreau @bryevdv
You can’t perform that action at this time.