Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSL certificate issues #104

Closed
rth opened this issue Feb 14, 2018 · 11 comments
Closed

SSL certificate issues #104

rth opened this issue Feb 14, 2018 · 11 comments

Comments

@rth
Copy link
Contributor

@rth rth commented Feb 14, 2018

Currently, the SSL certificate for https://www.python3statement.org/ appears to be invalid,

wget https://www.python3statement.org/ 
--2018-02-14 09:10:15--  https://www.python3statement.org/
Resolving www.python3statement.org... 151.101.61.147, 2a04:4e42:f::403
Connecting to www.python3statement.org|151.101.61.147|:443... connected.
The certificate's owner does not match hostname ‘www.python3statement.org’

anyone else seeing the same error? (I also get warning pages in Firefox and Chrome).

@takluyver
Copy link
Member

@takluyver takluyver commented Feb 14, 2018

This is a limitation of hosting websites on Github pages - the SSL certificate only covers the default foo.github.io address. It doesn't work if you have a custom domain. We just have to point people to the unencrypted version.

@rth
Copy link
Contributor Author

@rth rth commented Feb 14, 2018

Aww, you are right, thanks. I'm not sure how I ended up on the https version, I am fairly sure I didn't type https manually in the address bar, it must have been a link somewhere..

@rth rth closed this Feb 14, 2018
@Carreau Carreau reopened this Feb 14, 2018
@Carreau
Copy link
Member

@Carreau Carreau commented Feb 14, 2018

Let's reopen, I'll see if we can setup something like netlify in front of it that can get correct ssl certificate.

@Carreau
Copy link
Member

@Carreau Carreau commented Feb 14, 2018

@asmeurer, @takluyver, requesting authorization to change DNS nameservers to netlify ones to get automatic https letsencrypt certificate.

@Carreau
Copy link
Member

@Carreau Carreau commented Feb 14, 2018

That would be setting the DN servers to :

dns1.p01.nsone.net
dns2.p01.nsone.net
dns3.p01.nsone.net
dns4.p01.nsone.net

Mirror deployment is there:

https://python3statement.netlify.com/

Once DNS is set and propagated it's a click button to get an https certificate. I can make you admin of the netlify deployment as well of course.

@takluyver
Copy link
Member

@takluyver takluyver commented Feb 14, 2018

Fine by me. Will it still be automatically updated when we push to Github?

@Carreau
Copy link
Member

@Carreau Carreau commented Feb 14, 2018

Yes.

@Carreau
Copy link
Member

@Carreau Carreau commented Feb 14, 2018

Fine by me. Will it still be automatically updated when we push to Github?

On top of that, each PR is also built and get it's random subdomain, so we can check each PR before merging.

@takluyver
Copy link
Member

@takluyver takluyver commented Feb 14, 2018

Fancy!

@Carreau
Copy link
Member

@Carreau Carreau commented Feb 14, 2018

Ok, https should be valid now.

@takluyver
Copy link
Member

@takluyver takluyver commented Feb 14, 2018

Indeed it is - nice work!

@takluyver takluyver closed this Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.