Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python-gitlab #270

Merged
merged 1 commit into from Nov 3, 2019
Merged

Add python-gitlab #270

merged 1 commit into from Nov 3, 2019

Conversation

@max-wittig
Copy link
Contributor

@max-wittig max-wittig commented Nov 2, 2019

If you're adding a project to the Python 3 statement, please ensure you have:

  • Discussed dropping Python 2 support with all maintainers
  • Discussed signing the statement with all maintainers
  • Added a suitable logo if the project has one
    • Approximately square logos generally fit better than banners
    • Compressed the logo to save bandwidth (run scripts/squash-images.sh on it)
  • Checked the Netlify preview made from the pull request
@takluyver
Copy link
Member

@takluyver takluyver commented Nov 2, 2019

Thanks! The projects are ordered by stars count, so you can move it much further up the list - just after h5py, I think.

(Checked that @max-wittig is the main maintainer of python-gitlab)

@max-wittig max-wittig force-pushed the max-wittig:patch-1 branch from b564172 to 9307fdc Nov 3, 2019
@max-wittig
Copy link
Contributor Author

@max-wittig max-wittig commented Nov 3, 2019

@takluyver Thanks for the review. Order changed now.

@takluyver takluyver merged commit 7e6d411 into python3statement:master Nov 3, 2019
1 check passed
1 check passed
deploy/netlify Deploy preview ready!
Details
@takluyver
Copy link
Member

@takluyver takluyver commented Nov 3, 2019

Thanks, and welcome aboard!

@max-wittig max-wittig deleted the max-wittig:patch-1 branch Nov 4, 2019
@max-wittig
Copy link
Contributor Author

@max-wittig max-wittig commented Nov 4, 2019

@takluyver Thank you. Looking forward to 2020-01-01 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.