Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Apache Beam to the list of participating projects. #265

Merged
merged 1 commit into from Oct 10, 2019

Conversation

@tvalentyn
Copy link
Contributor

@tvalentyn tvalentyn commented Oct 5, 2019

If you're adding a project to the Python 3 statement, please ensure you have:

  • Discussed dropping Python 2 support with all maintainers.
  • Discussed signing the statement with all maintainers. See: voting thread for links to discussion and vote result.
  • Added a suitable logo if the project has one
    • Approximately square logos generally fit better than banners
    • Compressed the logo to save bandwidth (run scripts/squash-images.sh on it)
  • Checked the Netlify preview made from the pull request
@tvalentyn
Copy link
Contributor Author

@tvalentyn tvalentyn commented Oct 5, 2019

Thanks a lot for setting up and maintaining python3statement.org!
Do I have to add the autogenerated sg links in this pull request? If so, are there instructions somewhere? Our code lives at: https://github.com/apache/beam.

@takluyver
Copy link
Member

@takluyver takluyver commented Oct 5, 2019

Thanks! As you're linking to a non-Github site, I think it would be helpful if you could manually add the comment with the Github URL - there's a script which can use this to update the star counts and rearrange projects.

@tvalentyn tvalentyn force-pushed the tvalentyn:add_beam branch from c1aa997 to c6dd34d Oct 9, 2019
@tvalentyn
Copy link
Contributor Author

@tvalentyn tvalentyn commented Oct 9, 2019

Done, thanks.
I got "API rate limit exceeded" when running restar.py, so I did not update counters for other projects in this PR.

@takluyver takluyver merged commit a7d6865 into python3statement:master Oct 10, 2019
1 check passed
1 check passed
deploy/netlify Deploy preview ready!
Details
@takluyver
Copy link
Member

@takluyver takluyver commented Oct 10, 2019

Thanks. You don't need to run the star-count scripts as part of adding a project. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.