Skip to content

/ python3statement.github.io

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Dask #239

Merged
merged 1 commit into from Jun 20, 2019
Merged

Add Dask #239

merged 1 commit into from Jun 20, 2019

Conversation

@mrocklin
Copy link
Contributor

@mrocklin mrocklin commented Jun 20, 2019

This adds Dask to the Python 3 statement.

One question: I noticed that all of the images here are PNG. I uploaded an SVG (this just happens to be the most convenient for me at the moment) but I'd be happy to convert it as well.
@mrocklin
Add Dask
Loading status checks…
04f96a6
@mrocklin mrocklin mentioned this pull request Jun 20, 2019
Closed
@mrocklin
Copy link
Contributor Author

@mrocklin mrocklin commented Jun 20, 2019

I've asked for a few other Dask maintainers to +1 this PR to build authority behind it.
@jrbourbeau
Copy link

@jrbourbeau jrbourbeau commented Jun 20, 2019

+1 from me, thanks for adding this @mrocklin!
@TomAugspurger
Copy link

@TomAugspurger TomAugspurger commented Jun 20, 2019

+1
@hugovk
Copy link
Contributor

@hugovk hugovk commented Jun 20, 2019

SVG v. PNG: whichever is smallest! See #200. So probably SVG. :)
@mrocklin
Copy link
Contributor Author

@mrocklin mrocklin commented Jun 20, 2019

I'm definitely in favor of SVG generally. When I ran Jekyll locally I did find that the logo was quite small, so there might need to be a small CSS change somewhere.
@takluyver
Copy link
Member

@takluyver takluyver commented Jun 20, 2019

There's an automatically generated preview as well: https://deploy-preview-239--python3statement.netlify.com/

Inspecting the icon, it looks like we set max-width and max-height CSS properties, but the size the SVG 'wants' to be is smaller than that. I guess that's something that can be set in the SVG file itself? I don't think we should set height and width for all logos, because that stretches them to fill the bounding box.
@Carreau
Copy link
Member

@Carreau Carreau commented Jun 20, 2019

We can sett a min-width: 100px on the wrapping <li>, that seem to do the trick; and affect mostly the dask logo.
@Carreau
Copy link
Member

@Carreau Carreau commented Jun 20, 2019

Let's get that in; we can refine.

Thanks.
@Carreau Carreau merged commit 0f38170 into python3statement:master Jun 20, 2019
1 check passed
1 check passed
deploy/netlify Deploy preview ready!
Details
@hugovk
Copy link
Contributor

@hugovk hugovk commented Jun 20, 2019

Putting dask.svg through https://svgtopng.com:

 24K dask.png
2.3K dask.svg

After squashing:

  12K dask.png
 2.3K dask.svg

Big win for SVG.
@takluyver
Copy link
Member

@takluyver takluyver commented Jun 20, 2019

Now we just need pngtosvg.com! :-P
@Carreau
Copy link
Member

@Carreau Carreau commented Jun 20, 2019

Well svgs can include rasterized data right ?
Otherwise it's pretty easy to make lots of colored squares in SVG :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@mrocklin @jrbourbeau @TomAugspurger @hugovk @takluyver @Carreau
You can’t perform that action at this time.