Skip to content

/ python3statement.github.io

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ESMValTool project #259

Merged
merged 5 commits into from Sep 4, 2019
Merged

Adding ESMValTool project #259

merged 5 commits into from Sep 4, 2019

Conversation

@valeriupredoi
Copy link
Contributor

@valeriupredoi valeriupredoi commented Sep 2, 2019

Hey guys, adding our project to the list https://github.com/ESMValGroup/ESMValTool/ 🍺
@valeriupredoi
adding ESMValTool logo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
7748993
@valeriupredoi
added section for ESMValTool
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
cae91be
@valeriupredoi
added timeline for ESMValTool
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
f99c111
@valeriupredoi
Merge pull request #1 from valeriupredoi/valeriupredoi-add-esmvaltool
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
1c3e389 
adding ESMValTool project
@valeriupredoi
Copy link
Contributor Author

@valeriupredoi valeriupredoi commented Sep 2, 2019

also, super job in setting this one up! 🍻
@valeriupredoi valeriupredoi mentioned this pull request Sep 2, 2019
Closed
@takluyver
Copy link
Member

@takluyver takluyver commented Sep 3, 2019

Thanks! Have you discussed adding the project to the statement with any other maintainers? We try to ensure that no-one is surprised to see their project on the list.

You may want to use just the globe part of the logo - the layout works best with roughly square logos rather than narrow rectangles (see the preview). Up to you. Also, can you run scripts/squash-images.sh on the logo to compress it as small as possible?
@valeriupredoi
Copy link
Contributor Author

@valeriupredoi valeriupredoi commented Sep 4, 2019

Hi @takluyver cheers for getting back to me, yeah we have an open issue that all the ESMValTool core devs are aware of and they're all for it ESMValGroup/ESMValCore#23 - could we please keep the full globe + name of the package since that's the official logo; I will run the squashing script now tho 🍺 (apologies for the delayed reply, I was traveling yesterday)
@valeriupredoi
squashed esmvaltool logo
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
758c765
@takluyver
Copy link
Member

@takluyver takluyver commented Sep 4, 2019

OK, thanks!
@takluyver takluyver merged commit 337eb6a into python3statement:master Sep 4, 2019
1 check passed
1 check passed
deploy/netlify Deploy preview ready!
Details
@valeriupredoi
Copy link
Contributor Author

@valeriupredoi valeriupredoi commented Sep 4, 2019

smashing! cheers, guys, we're proud to be there with the lot 🍺
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@valeriupredoi @takluyver
You can’t perform that action at this time.